Add [set]DailyOffpeakTimeUTC option to Java API #13148
Conversation
| @@ -759,6 +759,19 @@ public long compactionReadaheadSize() { | |||
| return compactionReadaheadSize(nativeHandle_); | |||
| } | |||
|
|
|||
| @Override | |||
| public DBOptions setDailyOffpeakTimeUTC(String offpeakTimeUTC) { | |||
There was a problem hiding this comment.
I think this is good design. Somebody can say that java date/time data structures can be better, but conversion will probably make more problems. 👍
There was a problem hiding this comment.
I thought hard about that. If I would use the the java date/time, I need to parse the HH:mm-HH:mm format. Better to just present the same string as RockSDB does.
|
LGTM |
alanpaxton
force-pushed
the
eb/java-offpeak-compaction-options
branch
from
2bb94d2 to
a5cc7ab
Compare
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@alanpaxton Would you be able to rebase this PR? I will then re-import and merge the change. |
Reflect RocksDB DailyOffpeakTimeUTC option in Java API. As is standard for options, there are a number of different places where this option needs to be added. The new option is a string value. This requires an extension to the internal MutableDBOptions parse code, which received the entire options string from C++ and parses it on the Java side.
alanpaxton
force-pushed
the
eb/java-offpeak-compaction-options
branch
from
a5cc7ab to
1c742cb
Compare
|
@alanpaxton has updated the pull request. You must reimport the pull request before landing. |
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jaykorean merged this pull request in 9b1d0c0. |
Reflect RocksDB DailyOffpeakTimeUTC option in Java API. As is standard for options, there are a number of different places where this option needs to be added: it is an option, a DB option, and it is mutable (can be changed while running).
The new option is a string value. This requires an extension to the internal MutableDBOptions parse code, which received the entire options string from C++ and parses it on the Java side.